Skip to content

Commit

Permalink
pkp/pkp-lib#8437 Update db _settings table comments after review
Browse files Browse the repository at this point in the history
  • Loading branch information
NateWr committed Mar 9, 2023
1 parent 8b0baff commit 5801f70
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions classes/migration/install/CommonMigration.php
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public function up(): void
}

Schema::create('user_settings', function (Blueprint $table) {
$table->comment('Localized data about users, like their name and affiliation.');
$table->comment('More data about users, including localized properties like their name and affiliation.');
$table->bigInteger('user_id');
$table->foreign('user_id')->references('user_id')->on('users')->onDelete('cascade');
$table->index(['user_id'], 'user_settings_user_id');
Expand Down Expand Up @@ -220,7 +220,7 @@ public function up(): void
});

Schema::create('email_templates_settings', function (Blueprint $table) {
$table->comment('Localized data about custom email templates, such as the subject and body.');
$table->comment('More data about custom email templates, including localized properties such as the subject and body.');
$table->bigInteger('email_id');
$table->foreign('email_id', 'email_templates_settings_email_id')->references('email_id')->on('email_templates')->onDelete('cascade');
$table->index(['email_id'], 'email_templates_settings_email_id');
Expand Down
2 changes: 1 addition & 1 deletion classes/migration/install/ControlledVocabMigration.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public function up(): void

// Controlled vocabulary entry settings
Schema::create('controlled_vocab_entry_settings', function (Blueprint $table) {
$table->comment('Localized data about a controlled vocabulary entry, such as the actual word or phrase.');
$table->comment('More data about a controlled vocabulary entry, including localized properties such as the actual word or phrase.');
$table->bigInteger('controlled_vocab_entry_id');
$table->foreign('controlled_vocab_entry_id', 'c_v_e_s_entry_id')->references('controlled_vocab_entry_id')->on('controlled_vocab_entries')->onDelete('cascade');
$table->index(['controlled_vocab_entry_id'], 'c_v_e_s_entry_id');
Expand Down
2 changes: 1 addition & 1 deletion classes/migration/install/GenresMigration.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function up(): void

// Genre settings
Schema::create('genre_settings', function (Blueprint $table) {
$table->comment('Localized data about file genres, such as the genre name.');
$table->comment('More data about file genres, including localized properties such as the genre name.');
$table->bigInteger('genre_id');
$table->foreign('genre_id')->references('genre_id')->on('genres')->onDelete('cascade');
$table->index(['genre_id'], 'genre_settings_genre_id');
Expand Down
2 changes: 1 addition & 1 deletion classes/migration/install/RolesAndUserGroupsMigration.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function up(): void
});

Schema::create('user_group_settings', function (Blueprint $table) {
$table->comment('Localized data about user groups, such as the name.');
$table->comment('More data about user groups, including localized properties such as the name.');
$table->bigInteger('user_group_id');
$table->string('locale', 14)->default('');
$table->string('setting_name', 255);
Expand Down
4 changes: 2 additions & 2 deletions classes/migration/install/SubmissionsMigration.php
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public function up(): void

// publication metadata
Schema::create('publication_settings', function (Blueprint $table) {
$table->comment('Localized data about publications, such as the title and abstract.');
$table->comment('More data about publications, including localized properties such as the title and abstract.');
// The foreign key relationship on this table is defined with the publications table.
$table->bigInteger('publication_id');

Expand Down Expand Up @@ -111,7 +111,7 @@ public function up(): void

// Language dependent author metadata.
Schema::create('author_settings', function (Blueprint $table) {
$table->comment('Localized data about authors, such as their name and affiliation.');
$table->comment('More data about authors, including localized properties such as their name and affiliation.');
$table->bigInteger('author_id');
$table->foreign('author_id', 'author_settings_author_id')->references('author_id')->on('authors')->onDelete('cascade');
$table->index(['author_id'], 'author_settings_author_id');
Expand Down

0 comments on commit 5801f70

Please sign in to comment.