pkp/pkp-lib#8299 Fix representation policy

syauqiberbakti · Oct 4, 2022 · 9c997a8 · 9c997a8
1 parent 1987cc5
commit 9c997a8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/classes/security/authorization/internal/RepresentationRequiredPolicy.inc.php b/classes/security/authorization/internal/RepresentationRequiredPolicy.inc.php
@@ -46,7 +46,7 @@ function dataObjectEffect() {
 
 		// Make sure the representation belongs to the submission.
 		$representationDao = Application::getRepresentationDAO();
-		$representation = $representationDao->getById($representationId, $publication->getId(), null);
+		$representation = $representationDao->getById($representationId, $publication->getId());
 		if (!is_a($representation, 'Representation')) return AUTHORIZATION_DENY;
 
 		// Save the representation to the authorization context.

diff --git a/classes/submission/RepresentationDAO.inc.php b/classes/submission/RepresentationDAO.inc.php
@@ -20,7 +20,7 @@ abstract class RepresentationDAO extends DAO {
 	 * @param $representationId int Representation ID.
 	 * @param $publicationId int Optional publication ID.
 	 * @param $contextId int Optional context ID.
-	 * @return DAOResultFactory
+	 * @return Representation
 	 */
 	abstract function getById($representationId, $publicationId = null, $contextId = null);