Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacemacs buffer is not usable in holy-mode right now #1083

Closed
tuhdo opened this issue Apr 7, 2015 · 5 comments
Closed

Spacemacs buffer is not usable in holy-mode right now #1083

tuhdo opened this issue Apr 7, 2015 · 5 comments
Labels
Bug :-( Emacs style

Comments

@tuhdo
Copy link
Contributor

tuhdo commented Apr 7, 2015

Just a reminder from the discussion in this PR: #1070

To solve it, simply bind widget-button-press or evil-ret to RET and evil-mouse-drag to left mouse click.
@syl20bnr
Copy link
Owner

syl20bnr commented Apr 7, 2015

What do you mean by "Spacemacs is not usable" ? I just tried in emacs style and Spacemacs works great.
Do you mean that the widgets on the spacemacs buffer cannot be activated ?

@tuhdo
Copy link
Contributor Author

tuhdo commented Apr 7, 2015

Opss sorry for the misleading title. I meant "Spacemacs buffer", not Spacemacs :)

Currently the widgets are not usable as stated in the PR.

@tuhdo tuhdo changed the title Spacemacs is not usable in holy-mode right now Spacemacs buffer is not usable in holy-mode right now Apr 7, 2015
@tuhdo
Copy link
Contributor Author

tuhdo commented Apr 7, 2015

And yes, holy-mode is very usable now. I enjoy it everyday.

@syl20bnr
Copy link
Owner

syl20bnr commented Apr 7, 2015

Ouf I'm relieved :-)

@tuhdo
Copy link
Contributor Author

tuhdo commented Apr 12, 2015

@syl20bnr Just a reminder since you already merged the change log PR that there's an issue with holy-mode, in case you forgot.

tuhdo pushed a commit to tuhdo/spacemacs that referenced this issue Apr 13, 2015
[Fix syl20bnr#1083] Improve functionality of Spacemacs shortcuts
d4301a5 
Currently, `r` and `p` moves to different locations when the change log
text is folded/unfolded. Make it always jumps to the correct location
regardless of content of home buffer by actually search for it.

Also set keys to make home buffer usable with holy-mode.
syl20bnr pushed a commit that referenced this issue Apr 14, 2015
@syl20bnr
[Fix #1083] Improve functionality of Spacemacs shortcuts
a8858b8 
Currently, `r` and `p` moves to different locations when the change log
text is folded/unfolded. Make it always jumps to the correct location
regardless of content of home buffer by actually search for it.

Also set keys to make home buffer usable with holy-mode.

Conflicts:
	core/core-spacemacs-buffer.el
syl20bnr pushed a commit that referenced this issue Apr 14, 2015
@syl20bnr
[Fix #1083] Improve functionality of Spacemacs shortcuts
c59a89a 
Currently, `r` and `p` moves to different locations when the change log
text is folded/unfolded. Make it always jumps to the correct location
regardless of content of home buffer by actually search for it.

Also set keys to make home buffer usable with holy-mode.

Conflicts:
	core/core-spacemacs-buffer.el
gwydirsam added a commit to gwydirsam/spacemacs that referenced this issue Apr 14, 2015
@gwydirsam
Merge branch 'upstream-develop' into develop
296e1c4 
* upstream-develop: (82 commits)
  color layer: Don't fontify the startup buffer
  Remove shortcut button labels
  [Fix syl20bnr#1083] Improve functionality of Spacemacs shortcuts
  Beautify home buffer
  Edit purescript layer README and key bindings
  Suggest improvements for web-mode-micro-state
  Creates a really basic, early stages purescript layer.
  Make git-gutter keybindings work for both versions.
  Fix typo in syntax-checking layer.
  Update CHANGELOG.org
  color layer: define lightness and saturation for material and gotham
  Update change log
  Bump version to 0.101.1
  org layer: Exclude ox-gfm for now, seems to be problematic
  Fresh install, don't display the release notes at the next restart
  Remove shortuct on recent items header
  Display startup release note only if a dotfile exists
  Don't need to restart after first boot
  Comment default layers in template and add a comment
  Fix error loading non existing buffer cache file
  ...
taheris pushed a commit to taheris/spacemacs that referenced this issue Apr 15, 2015
Merge branch 'master' of http://github.com/syl20bnr/spacemacs
218bcff 
* 'master' of http://github.com/syl20bnr/spacemacs:
  Bump version to 0.101.2
  Update change log
  New dotfile variable `dotspacemacs-search-tools`
  color layer: Don't fontify the startup buffer
  Remove shortcut button labels
  [Fix syl20bnr#1083] Improve functionality of Spacemacs shortcuts
  Beautify home buffer
  Fix typo in syntax-checking layer.
  Update CHANGELOG.org
  Update change log
  org layer: Exclude ox-gfm for now, seems to be problematic
  Fresh install, don't display the release notes at the next restart
@tuhdo tuhdo closed this as completed Apr 23, 2015
kryptt pushed a commit to kryptt/spacemacs that referenced this issue Sep 6, 2015
@kryptt
[Fix syl20bnr#1083] Improve functionality of Spacemacs shortcuts
3b4a9a8 
Currently, `r` and `p` moves to different locations when the change log
text is folded/unfolded. Make it always jumps to the correct location
regardless of content of home buffer by actually search for it.

Also set keys to make home buffer usable with holy-mode.

Conflicts:
	core/core-spacemacs-buffer.el
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug :-( Emacs style
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syl20bnr @tuhdo