replace custom ivy hydra-menu by original hydra-menu #13377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 For this change, my only gripe is the missing |
|
Thank you for contributing to spacemacs 💜, I have squashed and cherry picked your commits into develop. @dalanicolai next time please take care that your PR has only one commit. To do so either force push on your PR branch or make single commits and squash them in the end. |
dalanicolai
deleted the
replace_custom_ivy_hydra_menu_with_updated_original
branch
|
Yeah I am learning git... and sometimes some things happen that I do not understand yet... anyway I will check things again and next time think about the squash |
|
I suspect this PR broke the completion if not using the |
Merged
smile13241324
pushed a commit
that referenced
this pull request
Mar 21, 2020
epsilon-0
pushed a commit
to epsilon-0/spacemacs
that referenced
this pull request
Apr 21, 2020
Ivy-hydra is autoloaded so the require statement here is unnecessary. Because this require (commented out) statement was here before I uncommented it in the last PR (syl20bnr#13377), I leave it here (commented out) as it was before that PR.
aam-at
pushed a commit
to aam-at/spacemacs
that referenced
this pull request
Mar 23, 2021
Ivy-hydra is autoloaded so the require statement here is unnecessary. Because this require (commented out) statement was here before I uncommented it in the last PR (syl20bnr#13377), I leave it here (commented out) as it was before that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the custom ivy hydra menu with the original (and updated) ivy hydra menu. Additionally checked parts of the documentation that required modification and applied them accordingly (no modifications were needed, only some additions)