Add support for the org-roam-server package #14613
Conversation
|
Don't merge this yet. I'm working on some improvements. |
layers/+emacs/org/README.org
Outdated
| org-enable-roam-server t))) | ||
| #+END_SRC | ||
|
|
||
| Do note that org-roam-server is more or less useless without org-roam. So you |
There was a problem hiding this comment.
org-enable-roam-support should default to t if org-enable-roam-server is non-nil. Then this paragraph is not needed.
There was a problem hiding this comment.
Don't merge this yet. I'm working on some improvements.
Exactly what I was working on.
There was a problem hiding this comment.
Although I seem to have been unsuccessful. It still just loads the package, but none of the keybindings.
layers/+emacs/org/README.org
Outdated
| @@ -391,7 +391,7 @@ To install org-roam support set the variable =org-enable-roam-support= to =t=. | |||
| More information about org-roam package (including manual) can be found at [[https://www.orgroam.com/][Org-roam]] website. | |||
|
|
|||
| ** Org-roam-server support | |||
| To install support for [[https://github.com/org-roam/org-roam-server][org-roam-server]] set the variable =org-enable-roam-server= | |||
| To enable support | |||
There was a problem hiding this comment.
I think you accidentally deleted too much here. Also I guess this section could be a subsection of Org-roam-support (add extra *)
layers/+emacs/org/packages.el
Outdated
| :init | ||
| (progn | ||
| (spacemacs/set-leader-keys "aors" 'org-roam-server-mode) | ||
| (spacemacs/set-leader-keys-for-major-mode 'org-mode "mrs" 'org-roam-server-mode)))) |
There was a problem hiding this comment.
When you use set-leader-keys-for-major-mode it will automatically get bound behind SPC m / ,, the binding will be available only in org-mode buffers (remove m)
|
Also, a single fix/addition should consist of a single commit. So it would be great if you could squash the commits in this PR, here is a guide (that duianto wrote for me when I also had too many commits :). I am not sure if you know about this section in the github wiki (just mentioning it). Generally when you add something to your PR (or any commit you would like to 'extend'), then you can add changes to the last commit by typing in magit either After you have modified commits with |
Co-authored-by: Lucius Hu <1222865+lebensterben@users.noreply.github.com>
KjartanOli
force-pushed
the
org-roam-server
branch
from
bca252b
to
99d403e
Compare
|
@dalanicolai Thanks for the links. It should all be squashed now. |
There was a problem hiding this comment.
Manually merged but noticed an issue with starting emacs without having org-roam configured.
I have fixed this during the merge in 5fd1976.
Next time please take some more time to test your PR before submitting.
|
Thank you for contributing to spacemacs 💜, I have cherry picked your commit into develop. |
Add support for the org-roam-server package. Which provides a convinient way of visualising the org-roam database.
Currently this PR requires the user to manually enable org-roam support by setting
org-enable-roam-support. Any suggestions on how to make that automatic are welcome.