Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed feature headers in README's #9508

Closed

Conversation

CeleritasCelery
Copy link
Contributor

@CeleritasCelery CeleritasCelery commented Aug 28, 2017

Updated the feature header in README's to match the Spacemacs style guide as requested in #9476.

Note that we have a spurious error in circleci

File "/root/project/layers/+source-control/version-control/README.org" has multiply "Features:" lists in the top level "Description" headline

which is incorrect. It looks like it is flagging this file because it has the word "feature" in a table. Hopefully @JAremko can fix that.

@JAremko
Copy link
Collaborator

JAremko commented Aug 29, 2017

@CeleritasCelery

File "/root/project/layers/+source-control/version-control/README.org" has multiply "Features:" lists in the top level "Description" headline

That's because you need extra white spaces before git-gutter, or git-gutter+ try this:

** Features:
- highlights uncommitted changes in the fringe or margin with [[https://github.com/dgutov/diff-hl][diff-hl]],
  git-gutter, or git-gutter+
- adds vcs transient-state ~SPC g.~ to allow quick navigation and modification of buffer hunks.

Without them there will be two lists (accordingly to org-mode parser 😏 )


Btw. What's up with your email/account? Can you fix it? 🤔

@CeleritasCelery CeleritasCelery force-pushed the whitespace-fix branch 2 times, most recently from 1704b35 to 4bdf6ee Compare August 29, 2017 16:12
@CeleritasCelery
Copy link
Contributor Author

Btw. What's up with your email/account? Can you fix it?

@JAremko What do you mean? Because I am using different credentials for commits then I am for the pull request? Is that a problem? I went ahead and rebased/reauthored my commits anyway.

@JAremko
Copy link
Collaborator

JAremko commented Aug 29, 2017

Because I am using different credentials for commits then I am for the pull request?

Yeah. We want your name in contributors 😉

@CeleritasCelery
Copy link
Contributor Author

I always wondered why I never got the "Contributor" tag. I assumed it was because all my commits were cherry-picked. Anyways, looks like the build is clean and all the documentation issues related to it are fixed.

@JAremko JAremko self-assigned this Aug 29, 2017
@JAremko
Copy link
Collaborator

JAremko commented Aug 29, 2017

Thank you ! 👍 Cherry-picked into develop branch, you can safely delete your branch.

@JAremko JAremko closed this Aug 29, 2017
@JAremko JAremko removed their assignment Aug 29, 2017
@CeleritasCelery CeleritasCelery deleted the whitespace-fix branch August 29, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants