Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support accented chars in search #734

Closed
ZHB opened this issue Dec 15, 2017 · 1 comment · Fixed by #735
Closed

Support accented chars in search #734

ZHB opened this issue Dec 15, 2017 · 1 comment · Fixed by #735

Comments

@ZHB
Copy link

ZHB commented Dec 15, 2017

Hello,

Currently query search sanitization replace all non alphanumeric chars :

preg_replace('/[^[:alnum:] ]/', '', ...);

and accented chars like éèà... are removed too, making posts not findable for accented articles. Maybe supporting accented chars would be nice for all non english people using this demo app as a base ?

@javiereguiluz
Copy link
Member

This definitely looks like a bug because we've translated this app into lots of languages with that kind of characters.

javiereguiluz added a commit that referenced this issue Dec 27, 2017
…uiluz)

This PR was merged into the master branch.

Discussion
----------

Allow to search blog posts with unicode characters

This fixes #734.

The search engine is now more strict because it's case sensitive (if the post title is `Lorém ipsum`, `lorém` and `Lorem` gives no results; you must search for `Lorém`). I'd say it's OK because we're not building a real search engine. Thoughts?

Commits
-------

0e1c9d3 Allow to search blog posts with unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants