Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced SwiftMailer by Symfony Mailer #1063

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Replaced SwiftMailer by Symfony Mailer #1063

merged 1 commit into from
Jan 15, 2020

Conversation

javiereguiluz
Copy link
Member

This fixes #1036.

@@ -31,7 +31,7 @@ protected function setUp()
exec('stty 2>&1', $output, $exitcode);
$isSttySupported = 0 === $exitcode;

if ('Windows' === \PHP_OS_FAMILY || !$isSttySupported) {
if ('Windows' === PHP_OS_FAMILY || !$isSttySupported) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious. Why this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unrelated to this pull request ... but without this change, the php-cs-fixer linter shows an error. I was lazy and did the change here instead of creating a new PR 🙈

@javiereguiluz javiereguiluz merged commit c5df9b7 into symfony:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Swiftmailer with Mailer Component
3 participants