Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on composer/package-versions-deprecated #1310

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

stof
Copy link
Member

@stof stof commented Jan 12, 2022

This package was added in the past to force keeping support for composer 1 when using doctrine/orm. In the meantime, doctrine/orm has switched to using that package directly, making this root requirement useless. And in the next releases of doctrine/orm and doctrine/dbal, they are migrating to use composer-runtime-api (dropping support for composer 1) instead of using this plugin, as part of the effort to fade out that compat plugin.

Refs symfony/symfony#44726

The package is still present for now (and so still needed in the list of allowed plugins too) because doctrine packages require it. But this will change in their next releases for DBAL, ORM and Migrations (the PRs are already merged)

This package was added in the past to force keeping support for composer
1 when using doctrine/orm. In the meantime, doctrine/orm has switched to
using that package directly, making this root requirement useless.
And in the next releases of doctrine/orm and doctrine/dbal, they are
migrating to use composer-runtime-api (dropping support for composer 1)
instead of using this plugin, as part of the effort to fade out that
compat plugin.
Copy link
Contributor

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javiereguiluz
Copy link
Member

Thank you Christophe.

@javiereguiluz javiereguiluz merged commit 741aa2e into symfony:main Jan 14, 2022
@stof stof deleted the remove_old_dependency branch January 14, 2022 12:51
javiereguiluz added a commit to javiereguiluz/demo that referenced this pull request Dec 8, 2022
…llow-plugins (rosier)

This PR was merged into the main branch.

Discussion
----------

Remove composer/package-versions-deprecated from allow-plugins

The plugin composer/package-versions-deprecated is no longer in use.

Followup of symfony#1310

Commits
-------

4b1db23 Remove composer/package-versions-deprecated from allow-plugins and sort config keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants