Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor code fixes found with PhpStorm, Php Inspections and PHPStan #757

Closed
wants to merge 3 commits into from
Closed

Minor code fixes found with PhpStorm, Php Inspections and PHPStan #757

wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

No description provided.

yceruto
yceruto approved these changes Jan 30, 2018
View reviewed changes
src/Entity/Comment.php
{
return $this->post;
}

public function setPost(Post $post): void
public function setPost(?Post $post): void
Copy link
Member

@yceruto yceruto Jan 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, could we do the same on Post::setTitle() & Co. to fix #741?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Done.

@javiereguiluz javiereguiluz mentioned this pull request Jan 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
FINISHED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javiereguiluz @yceruto