Drop ESLint and Prettier for Biome #1848
Conversation
|
Failures are unrelated |
|
I cannot resist to answer with: https://dayssincelastjavascriptframework.com/ (and now more seriously i'll look at your post 😅 ) |
|
(first read: you know how to speak to me :) ) |
|
Yeah I know about the 0 day since the last JS framework/tools meme... and trust me it's not for nothing my TN is "JS hate account" Biome is a community-fork from Rome (started 3 years ago), it's a tool I was really looking forward to because of the over-fragmentation of JavaScript tools and the unnecessarily complex configurations to make them work together. I consider Biome enough "production-ready", to nicely and quickly lint and format our JS(X)/TS(X) files. |
|
What about editor integration? Did you tried the PHPstorm extension? Do you think it's mature enough? |
|
I didn't know an extension existed, and so I didn't try it. But I'm not a big fan of ESLint/Prettier integration in IDEs, I prefer relying on CLI / CI / pre-commit hook :D |
|
I'll try it next week (late in the week) ! |
| @@ -57,7 +55,7 @@ export default class extends Controller<HTMLInputElement> { | |||
| button.classList.add(...this.buttonClassesValue); | |||
| button.setAttribute('tabindex', '-1'); | |||
| button.addEventListener('click', this.toggle.bind(this)); | |||
| button.innerHTML = this.visibleIcon + ' ' + this.visibleLabelValue; | |||
| button.innerHTML = `${this.visibleIcon} ${this.visibleLabelValue}`; | |||
There was a problem hiding this comment.
Is this worth the change ?
There was a problem hiding this comment.
Yes, string concatenation with + is a mistake
| "workspaces": [ | ||
| "src/*/assets" | ||
| ], | ||
| "workspaces": ["src/*/assets"], | ||
| "scripts": { | ||
| "build": "node bin/build_javascript.js && node bin/build_styles.js", | ||
| "test": "bin/run-vitest-all.sh", |
There was a problem hiding this comment.
Any impact on those two ? (build / test)
There was a problem hiding this comment.
Mmmh nope, it is not related to Biome and they still works
Kocal
force-pushed
the
chore/replace-eslint-and-prettier-by-biomejs
branch
from
e65d382
to
97dd32d
Compare
Kocal
force-pushed
the
chore/replace-eslint-and-prettier-by-biomejs
branch
from
97dd32d
to
79953e3
Compare
… of a function (it requires a prototype)
Kocal
force-pushed
the
chore/replace-eslint-and-prettier-by-biomejs
branch
from
79953e3
to
a999295
Compare
Hi everyone,
Biome is a new modern tool for code linting and formatting.
It supports TypeScript out-of-the-box, lint and format does not conflict each-other (like ESLint and Prettier can do), and it's super fast!
With Biome, we can easily replace:
There is a lot of modifications, but 99% of them are:
import type .../import { type ... }when necessary'use strict', since we havetype: 'module'inpackage.jsonfiles, but I'm not 100% confidente here and I may add them back+operatorI've disabled the following linting rules in order to reduce the number of modifications, but later we can start to enable them:
complexity/noStaticOnlyClasscomplexity/noForEachstyle/noParameterAssignperformance/noDeleteThe yarn scripts
lint,format,check-lintandcheck-formathave been modified in consequences.For performance comparisons, you can check those two CI jobs:
For the number of commits, I wanted to ease the review by doing many atomic commits, but feel free to squash if necessary.
WDYT?