Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solhint warning fixes [SLT-287] #3207

Merged
merged 2 commits into from
Oct 1, 2024

named vars on overloads

95daba4
Select commit
Loading
Failed to load commit list.
Merged

solhint warning fixes [SLT-287] #3207

named vars on overloads
95daba4
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither completed Oct 1, 2024 in 4s

1 configuration not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 1 configuration present on refs/heads/master was not found:

Actions workflow (solidity.yml)

  • ❓  .github/workflows/solidity.yml:slither/package:contracts-core

New alerts in code changed by this pull request

Security Alerts:

  • 4 low

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 122 in packages/contracts-rfq/contracts/FastBridgeV2.sol

See this annotation in the file changed.

Code scanning / Slither

Block timestamp Low

FastBridgeV2.dispute(bytes32) uses timestamp for comparisons
Dangerous comparisons:
- _timeSince(bridgeTxDetails[transactionId].proofBlockTimestamp) > DISPUTE_PERIOD

Check notice on line 150 in packages/contracts-rfq/contracts/FastBridgeV2.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in FastBridgeV2.refund(bytes):
External calls:
- token.universalTransfer(to,amount)
Event emitted after the call(s):
- BridgeDepositRefunded(transactionId,to,token,amount)

Check notice on line 150 in packages/contracts-rfq/contracts/FastBridgeV2.sol

See this annotation in the file changed.

Code scanning / Slither

Block timestamp Low

FastBridgeV2.refund(bytes) uses timestamp for comparisons
Dangerous comparisons:
- block.timestamp <= transaction.deadline
- block.timestamp <= transaction.deadline + REFUND_DELAY

Check notice on line 157 in packages/contracts-rfq/contracts/FastBridgeV2.sol

See this annotation in the file changed.

Code scanning / Slither

Block timestamp Low

FastBridgeV2.canClaim(bytes32,address) uses timestamp for comparisons
Dangerous comparisons:
- _timeSince(bridgeTxDetails[transactionId].proofBlockTimestamp) > DISPUTE_PERIOD