Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pimlico proxy #3311

Closed
wants to merge 1 commit into from
Closed

add pimlico proxy #3311

wants to merge 1 commit into from

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Oct 18, 2024

Description

Adds pimlico proxy

Summary by CodeRabbit

  • New Features
    • Introduced a new command pimlicoProxy to the command-line interface, enhancing the functionality of the omniproxy service.
    • Added a command-line flag pimlicoFlag to specify a Pimlico URL for requests, improving configurability.
    • Launched a new proxy service for handling RPC requests within the Pimlico framework.

Copy link
Contributor

coderabbitai bot commented Oct 18, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a new command, pimlicoProxy, to the command-line interface (CLI) application for the omniproxy service. This command serves as an RPC proxy for the Pimlico service and includes several associated flags. Additionally, a new module for the Pimlico proxy service is created, defining the interface and implementing the necessary functionalities to handle RPC requests. The changes enhance the overall capabilities of the CLI application by allowing users to specify a Pimlico URL and manage RPC calls effectively.

Changes

File Path Change Summary
services/omnirpc/cmd/cmd.go Added new command pimlicoProxy.
services/omnirpc/cmd/commands.go Introduced pimlicoProxy command with attributes and created a proxy instance using pimlico.NewProxy. Added import for pimlico.
services/omnirpc/cmd/flags.go Added new command-line flag pimlicoFlag for specifying a Pimlico URL.
services/omnirpc/modules/pimlico/pimlico.go Created a new file for the Pimlico proxy service, defining the PimlicoProxy interface and implementing the pimlicoProxyImpl struct with methods for handling RPC requests.

Poem

In the land of code where rabbits play,
A new command hops in, brightening the day.
With pimlicoProxy, requests take flight,
Guiding the way through the digital night.
Flags waving high, a URL to share,
In the garden of functions, we flourish with care! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@trajan0x trajan0x closed this Oct 18, 2024
@trajan0x trajan0x deleted the feat/pimlico-proxy branch October 18, 2024 13:47
@github-actions github-actions bot added go Pull requests that update Go code size/s labels Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 120 lines in your changes missing coverage. Please review.

Project coverage is 24.75389%. Comparing base (6415acd) to head (374cd48).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
services/omnirpc/modules/pimlico/pimlico.go 0.00000% 111 Missing ⚠️
services/omnirpc/cmd/commands.go 0.00000% 8 Missing ⚠️
services/omnirpc/cmd/cmd.go 0.00000% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6415acd) and HEAD (374cd48). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (6415acd) HEAD (374cd48)
solidity 2 0
Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #3311         +/-   ##
===================================================
- Coverage   31.92469%   24.75389%   -7.17080%     
===================================================
  Files            238         329         +91     
  Lines          14553       21738       +7185     
  Branches         356          82        -274     
===================================================
+ Hits            4646        5381        +735     
- Misses          9614       15845       +6231     
- Partials         293         512        +219     
Flag Coverage Δ
cctp-relayer 31.97848% <ø> (?)
omnirpc 30.96179% <0.00000%> (?)
opbot 0.48870% <ø> (ø)
promexporter 6.81642% <ø> (ø)
rfq 24.71101% <ø> (+0.09814%) ⬆️
scribe 18.24614% <ø> (?)
solidity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code needs-go-generate-services/rfq size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant