remove duplicate SyncthingRunnable start trigger (fixes #1104) #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll leave for @Nutomic |
Catfriend1
changed the title
… into fixDoubleBinaryStarts
|
Yes that makes sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In issue #1104, I discovered faulty startup behaviour of the SyncthingService. It starts the SyncthingRunnable.run() two times which results in one starting binary instance getting killed as "two instances running" will be caught by the app and fixed.
Cause is,
| new DeviceStateHolder(SyncthingService.this, this::updateState);
already has a callback to
| updateState()
and does call it in foreground running mode and in background running condition.
Sidenote
I also suspect the "two simultaneously" starting syncthing binary instances to be the cause of some people's reported config corruption issue, e.g. https://forum.syncthing.net/t/all-settings-are-gone-after-updating-app/11514/9 .
Testing
Verified correctly working on commit 976b475 under Android 7.1.2, device lg-h815.