Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/eliminate aggregate #28

Closed
wants to merge 31 commits into from
Closed

Feature/eliminate aggregate #28

wants to merge 31 commits into from
+119 −30

Conversation

mertak-synnada
Copy link

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

metesynnada and others added 12 commits February 22, 2024 09:56
@metesynnada
Delete docs.yaml
10000fb
@mustafasrepo
Merge pull request #5 from synnada-ai/ci-action-fixing
6c76423 
Fix deploying DataFusion site error
@mustafasrepo
Merge branch 'apache:main' into main
599516b
@mustafasrepo
Merge branch 'apache:main' into main
b20b65c
@mustafasrepo
Merge branch 'apache:main' into main
6c066b9
@mustafasrepo
Merge remote-tracking branch 'upstream/main'
6770106
@mustafasrepo
Merge branch 'apache:main' into main
38db3d8
@mustafasrepo
Merge branch 'apache:main' into main
e21ac2b
@mustafasrepo
Merge branch 'apache:main' into main
b7e6320
@mustafasrepo
Merge branch 'apache:main' into main
d6e39a4
initialize eliminate_aggregate.rs rule
a2e53c2
Merge remote-tracking branch 'refs/remotes/origin/apache_main' into f…
79d82a0 
…eature/eliminate-aggregate

# Conflicts:
#	.github/workflows/docs.yaml
#	datafusion/optimizer/src/lib.rs
#	datafusion/optimizer/src/optimizer.rs
#	datafusion/optimizer/src/single_distinct_to_groupby.rs
@mertak-synnada mertak-synnada marked this pull request as draft August 1, 2024 15:21
simplify function
a8e1b05 
add additional tests for not removing cases
@mertak-synnada mertak-synnada self-assigned this Aug 2, 2024
@mertak-synnada mertak-synnada marked this pull request as ready for review August 2, 2024 10:56
ozankabak
ozankabak reviewed Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if we can fix the already existing rule instead of adding a new one. Also added a possible simplification to functional dependencies diff.

datafusion/common/src/functional_dependencies.rs Outdated Show resolved Hide resolved
ozankabak
ozankabak reviewed Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible further simplifications

datafusion/optimizer/src/replace_distinct_aggregate.rs Outdated Show resolved Hide resolved
datafusion/optimizer/src/replace_distinct_aggregate.rs Outdated Show resolved Hide resolved
ozankabak
ozankabak approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready to go

datafusion/common/src/functional_dependencies.rs Outdated Show resolved Hide resolved
@ozankabak
Copy link
Collaborator

Merged upstream.

@ozankabak ozankabak closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozankabak ozankabak ozankabak approved these changes

Assignees

@mertak-synnada mertak-synnada

Labels
optimizer sqllogictest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mertak-synnada @ozankabak @metesynnada @mustafasrepo