Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fix: Enforce sorting #31

Closed
wants to merge 30 commits into from
Closed

minor fix: Enforce sorting #31

wants to merge 30 commits into from

Conversation

mustafasrepo
Copy link
Collaborator

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

ozankabak
ozankabak reviewed Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should rename the remove_corresponding_coalesce_in_sub_plan function because it also removes ineffective repartition operators. Let's update its docstring and find it a new name. Maybe reoptimize_partitioning?

datafusion/core/src/dataframe/mod.rs Show resolved Hide resolved
datafusion/core/src/physical_optimizer/enforce_sorting.rs Outdated Show resolved Hide resolved
datafusion/core/src/physical_optimizer/enforce_sorting.rs Outdated Show resolved Hide resolved
datafusion/core/src/physical_optimizer/enforce_sorting.rs Outdated Show resolved Hide resolved
datafusion/core/src/physical_optimizer/sort_pushdown.rs Outdated Show resolved Hide resolved
datafusion/core/src/physical_optimizer/sort_pushdown.rs Outdated Show resolved Hide resolved
datafusion/core/src/physical_optimizer/sort_pushdown.rs Outdated Show resolved Hide resolved
datafusion/core/src/physical_optimizer/sort_pushdown.rs Outdated Show resolved Hide resolved
ozankabak
ozankabak approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 9, 2024
@ozankabak
Copy link
Collaborator

Merged upstream.

@ozankabak ozankabak closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozankabak ozankabak ozankabak approved these changes

Assignees
No one assigned
Labels
core documentation Improvements or additions to documentation sqllogictest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mustafasrepo @ozankabak