Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG support #4

Closed
abruzzihraig opened this issue Dec 11, 2017 · 1 comment
Closed

SVG support #4

abruzzihraig opened this issue Dec 11, 2017 · 1 comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have

Comments

@abruzzihraig
Copy link

Hi, I just noticed there is a camel case issue in SVG. The property 'viewBox' will be parsed as 'view-box' in the produced HTML.

e.g.
Input

h('svg', {
    fill: '#000000',
    height: 24,
    width: 24,
    viewBox: '0 0 24 24',
    xmlns: 'http://www.w3.org/2000/svg',
    class: 'carousel-prev-step'
}

Output

<svg fill="#000000" height="24" width="24" view-box="0 0 24 24" xmlns="http://www.w3.org/2000/svg" class="carousel-prev-step"><path d="M15.41 7.41L14 6l-6 6 6 6 1.41-1.41L10.83 12z"></path><path d="M0 0h24v24H0z" fill="none"></path></svg>

The expected result should be <svg viewBox="0 0 24 24">

@wooorm
Copy link
Member

wooorm commented Jun 24, 2018

Hey @abruzzihraig!

Sorry for the delay!

I thought about it a bit and I’d like to work on this now. For starters, this issue is now first tracked in wooorm/property-information#6. When that is done, we can work on updating it throughout the ecosystem.

I’ll close this now, if you have any further comments please post them there!

@wooorm wooorm closed this as completed Jun 24, 2018
wooorm added a commit that referenced this issue Jul 17, 2018
Related to wooorm/property-information#6.
Related to GH-6.
Related to GH-4.
@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🧑 semver/major This is a change labels Aug 11, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Development

No branches or pull requests

2 participants