feat: Have breakpoints accept custom media queries #1653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
Currently breakpoints generate mobile-first (i.e. min-width) media queries which does not work for every usecase.
Our team e.g. uses on breakpoint that is only relevant if the screen's orientation is "landscape".
Describe your solution
In addition to accepting a the min-width as a string, breakpoints can now also consist of full media queries.
This is done, by checking, whether the breakpoint string contains "@media". In that case the custom media query is used to create the css.
If the breakpoint does not include "@media", the mobile-first media query is used, just like before.
A breakpoint array like this:
now results in the following generated media queries:
This solution does not result in any breaking changes.
I updated the documentation and the CHANGELOG accordingly.
📦 Published PR as canary version:
0.6.3--canary.1653.a955910.0
✨ Test out this PR locally via:
npm install @theme-ui/color-modes@0.6.3--canary.1653.a955910.0 npm install @theme-ui/color@0.6.3--canary.1653.a955910.0 npm install @theme-ui/components@0.6.3--canary.1653.a955910.0 npm install @theme-ui/core@0.6.3--canary.1653.a955910.0 npm install @theme-ui/css@0.6.3--canary.1653.a955910.0 npm install @theme-ui/custom-properties@0.6.3--canary.1653.a955910.0 npm install @theme-ui/editor@0.6.3--canary.1653.a955910.0 npm install gatsby-plugin-theme-ui@0.6.3--canary.1653.a955910.0 npm install gatsby-theme-code-recipes@0.6.3--canary.1653.a955910.0 npm install gatsby-theme-style-guide@0.6.3--canary.1653.a955910.0 npm install gatsby-theme-ui-layout@0.6.3--canary.1653.a955910.0 npm install @theme-ui/match-media@0.6.3--canary.1653.a955910.0 npm install @theme-ui/mdx@0.6.3--canary.1653.a955910.0 npm install @theme-ui/parse-props@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-base@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-bootstrap@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-bulma@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-dark@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-deep@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-funk@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-future@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-polaris@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-roboto@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-sketchy@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-swiss@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-system@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-tailwind@0.6.3--canary.1653.a955910.0 npm install @theme-ui/preset-tosh@0.6.3--canary.1653.a955910.0 npm install @theme-ui/presets@0.6.3--canary.1653.a955910.0 npm install @theme-ui/prism@0.6.3--canary.1653.a955910.0 npm install @theme-ui/sidenav@0.6.3--canary.1653.a955910.0 npm install @theme-ui/style-guide@0.6.3--canary.1653.a955910.0 npm install @theme-ui/tachyons@0.6.3--canary.1653.a955910.0 npm install @theme-ui/tailwind@0.6.3--canary.1653.a955910.0 npm install @theme-ui/theme-provider@0.6.3--canary.1653.a955910.0 npm install theme-ui@0.6.3--canary.1653.a955910.0 npm install @theme-ui/typography@0.6.3--canary.1653.a955910.0 # or yarn add @theme-ui/color-modes@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/color@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/components@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/core@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/css@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/custom-properties@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/editor@0.6.3--canary.1653.a955910.0 yarn add gatsby-plugin-theme-ui@0.6.3--canary.1653.a955910.0 yarn add gatsby-theme-code-recipes@0.6.3--canary.1653.a955910.0 yarn add gatsby-theme-style-guide@0.6.3--canary.1653.a955910.0 yarn add gatsby-theme-ui-layout@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/match-media@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/mdx@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/parse-props@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-base@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-bootstrap@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-bulma@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-dark@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-deep@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-funk@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-future@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-polaris@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-roboto@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-sketchy@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-swiss@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-system@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-tailwind@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/preset-tosh@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/presets@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/prism@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/sidenav@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/style-guide@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/tachyons@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/tailwind@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/theme-provider@0.6.3--canary.1653.a955910.0 yarn add theme-ui@0.6.3--canary.1653.a955910.0 yarn add @theme-ui/typography@0.6.3--canary.1653.a955910.0