Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 Suppport + Bump Obsidian to 1.0.3 #25

Merged
merged 8 commits into from
Nov 21, 2022
Merged

Conversation

just5ky
Copy link
Contributor

@just5ky just5ky commented Nov 16, 2022

  • For the new GH action to work:
    • Need to add DOCKERHUB_USERNAME & DOCKERHUB_TOKEN to publish image to Dockerhub
    • Need to uncomment Line 40 to 45, provide GIT_TOKEN & add ghcr.io/${{ github.repository }} to line 49 of Github action to publish image to ghcr.io

Fixing

Dockerhub ref: https://hub.docker.com/r/justsky/obsidian-remote

@Hoempi
Copy link

Hoempi commented Nov 16, 2022

Ah, good to see. Just started my local Obsidian and realized the update to 1.0.3 and was wondering about my PR to update to 1.0.0. I'll delete that.

@sytone
Copy link
Owner

sytone commented Nov 18, 2022

DOCKERHUB_USERNAME & DOCKERHUB_TOKEN have been added as secrets.

@sytone
Copy link
Owner

sytone commented Nov 18, 2022

secrets.GIT_TOKEN exists by default already. I assume this would replace the existing workflow?

@just5ky
Copy link
Contributor Author

just5ky commented Nov 19, 2022

We always remame the keyword if you are using it for something else
But git.token will store GitHub token and will push the container to ghcr.io

@sytone
Copy link
Owner

sytone commented Nov 21, 2022

ok, given simplicity of this project just going to leave the defaults so you can uncomment the GH section.

@sytone
Copy link
Owner

sytone commented Nov 21, 2022

ill just merge for now to get the docker package out. will fix GHCR later

@sytone sytone merged commit 5431ad7 into sytone:main Nov 21, 2022
@just5ky just5ky mentioned this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants