-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM64 Suppport + Bump Obsidian to 1.0.3 #25
Conversation
Ah, good to see. Just started my local Obsidian and realized the update to 1.0.3 and was wondering about my PR to update to 1.0.0. I'll delete that. |
DOCKERHUB_USERNAME & DOCKERHUB_TOKEN have been added as secrets. |
secrets.GIT_TOKEN exists by default already. I assume this would replace the existing workflow? |
We always remame the keyword if you are using it for something else |
ok, given simplicity of this project just going to leave the defaults so you can uncomment the GH section. |
ill just merge for now to get the docker package out. will fix GHCR later |
DOCKERHUB_USERNAME
&DOCKERHUB_TOKEN
to publish image to DockerhubGIT_TOKEN
& addghcr.io/${{ github.repository }}
to line 49 of Github action to publish image to ghcr.ioFixing
Dockerhub ref: https://hub.docker.com/r/justsky/obsidian-remote