Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow drawing outside canvas for a smoother signature #765

Merged
merged 11 commits into from
Apr 5, 2024

Conversation

UziTech
Copy link
Collaborator

@UziTech UziTech commented Apr 3, 2024

Allow drawing points outside of the canvas so the signature looks smoother at the edges

Current version:

sig1

This PR:

sig2

Changelog

BREAKING CHANGE:

  • Drawing outside of the canvas will record data outside the canvas
  • Update SignatureEvent to store the original event, x, y, pressure
  • move and up events are attached once down is triggered and they are on the window/ownerDocument target

@UziTech UziTech marked this pull request as ready for review April 3, 2024 07:07
@UziTech UziTech changed the base branch from beta to master April 3, 2024 07:43
@UziTech UziTech changed the base branch from master to beta April 3, 2024 07:47
@UziTech UziTech changed the title allow drawing outside canvas for a smoother looking signature allow drawing outside canvas for a smoother signature Apr 4, 2024
@UziTech UziTech merged commit 4d31ade into szimek:beta Apr 5, 2024
5 checks passed
@UziTech UziTech changed the title allow drawing outside canvas for a smoother signature fix: allow drawing outside canvas for a smoother signature Apr 5, 2024
@UziTech UziTech deleted the draw-outside-canvas branch April 5, 2024 01:25
UziTech added a commit that referenced this pull request Apr 5, 2024
BREAKING CHANGE:

- Drawing outside of the canvas will record data outside the canvas
- Update SignatureEvent to store the original event, x, y, pressure
- move and up events are attached once down is triggered and they are on the window/ownerDocument target
UziTech added a commit that referenced this pull request Apr 5, 2024
BREAKING CHANGE:

- Drawing outside of the canvas will record data outside the canvas
- Update SignatureEvent to store the original event, x, y, pressure
- move and up events are attached once down is triggered and they are on the window/ownerDocument target
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
# [5.0.0-beta.1](v4.2.0...v5.0.0-beta.1) (2024-04-05)

### Bug Fixes

* allow drawing outside canvas for a smoother signature ([#765](#765)) ([29a8b5a](29a8b5a))

### BREAKING CHANGES

* - Drawing outside of the canvas will record data outside the canvas
- Update SignatureEvent to store the original event, x, y, pressure
- move and up events are attached once down is triggered and they are on the window/ownerDocument target
github-actions bot pushed a commit that referenced this pull request May 3, 2024
# [5.0.0](v4.2.0...v5.0.0) (2024-05-03)

### Bug Fixes

* allow drawing outside canvas for a smoother signature ([#765](#765)) ([29a8b5a](29a8b5a))
* update deps ([1955364](1955364))

### BREAKING CHANGES

* - Drawing outside of the canvas will record data outside the canvas
- Update SignatureEvent to store the original event, x, y, pressure
- move and up events are attached once down is triggered and they are on the window/ownerDocument target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant