Prevent crash when use lib inside webcomponent #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/t1m0n/air-datepicker/AdVT99cddhgN4nLbwsVP4Hnb1SPk |
t1m0n
reviewed
Oct 25, 2021
src/utils.js
Outdated
| @@ -293,6 +293,8 @@ export function addEventListener(el, type, listener) { | |||
| export function closest(target, selector) { | |||
| if (!target || target === document) return false; | |||
|
|
|||
| if (typeof target.matches !== 'function') return false; | |||
There was a problem hiding this comment.
Hi! Thanks for your PR, maybe it is better to add check against DocumentFragment for better understanding what is happening?
if (!target || target === document || target instanceof DocumentFragment) return false;What do you think?
There was a problem hiding this comment.
Hi! Yes, i believe that it looks better
pleomax13
pushed a commit
to pleomax13/air-datepicker
that referenced
this pull request
Jun 6, 2023
Prevent crash when use lib inside webcomponent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this lib inside Stencil webcomponent with shadow dom activated. The problem is when the closest funtion is trying to find a document element because inside shadowDorm we have not a document element, we have a document-fragment element without matches function so for that i added an if to return false in that case because we able to asume that is the last parent or cant continue finding more nodes.