Skip to content

Commit

Permalink
Add minor safety to DROP INDEX/TABLE statements in migrations
Browse files Browse the repository at this point in the history
  • Loading branch information
turt2live committed Aug 20, 2023
1 parent df8084b commit bfbe067
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 22 deletions.
4 changes: 2 additions & 2 deletions migrations/11_add_reserved_ids_table_down.sql
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
DROP INDEX reserved_media_index;
DROP TABLE reserved_media;
DROP INDEX IF EXISTS reserved_media_index;
DROP TABLE IF EXISTS reserved_media;
6 changes: 3 additions & 3 deletions migrations/13_add_export_tables_down.sql
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
DROP INDEX export_parts_index;
DROP TABLE export_parts;
DROP TABLE exports;
DROP INDEX IF EXISTS export_parts_index;
DROP TABLE IF EXISTS export_parts;
DROP TABLE IF EXISTS exports;
6 changes: 3 additions & 3 deletions migrations/16_add_media_attributes_table_down.sql
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
DROP INDEX idx_media_attributes_purpose;
DROP INDEX idx_media_attributes;
DROP TABLE media_attributes;
DROP INDEX IF EXISTS idx_media_attributes_purpose;
DROP INDEX IF EXISTS idx_media_attributes;
DROP TABLE IF EXISTS media_attributes;
12 changes: 6 additions & 6 deletions migrations/1_create_tables_down.sql
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
DROP INDEX media_index;
DROP INDEX thumbnails_index;
DROP INDEX url_previews_index;
DROP TABLE url_previews;
DROP TABLE thumbnails;
DROP TABLE media;
DROP INDEX IF EXISTS media_index;
DROP INDEX IF EXISTS thumbnails_index;
DROP INDEX IF EXISTS url_previews_index;
DROP TABLE IF EXISTS url_previews;
DROP TABLE IF EXISTS thumbnails;
DROP TABLE IF EXISTS media;
4 changes: 2 additions & 2 deletions migrations/20_create_id_hold_table_down.sql
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
DROP INDEX idx_media_id_hold;
DROP TABLE media_id_hold;
DROP INDEX IF EXISTS idx_media_id_hold;
DROP TABLE IF EXISTS media_id_hold;
2 changes: 1 addition & 1 deletion migrations/2_add_animated_col_down.sql
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
DROP INDEX thumbnails_index;
DROP INDEX IF EXISTS thumbnails_index;
CREATE UNIQUE INDEX IF NOT EXISTS thumbnails_index ON thumbnails (media_id, origin, width, height, method);
ALTER TABLE thumbnails DROP COLUMN animated;
2 changes: 1 addition & 1 deletion migrations/2_add_animated_col_up.sql
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ALTER TABLE thumbnails ADD COLUMN animated BOOL NOT NULL DEFAULT FALSE;
DROP INDEX thumbnails_index;
DROP INDEX IF EXISTS thumbnails_index;
CREATE UNIQUE INDEX IF NOT EXISTS thumbnails_index ON thumbnails (media_id, origin, width, height, method, animated);
4 changes: 2 additions & 2 deletions migrations/6_track_last_accessed_times_down.sql
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
DROP INDEX last_access_index;
DROP TABLE last_access;
DROP INDEX IF EXISTS last_access_index;
DROP TABLE IF EXISTS last_access;
4 changes: 2 additions & 2 deletions migrations/7_add_datastore_down.sql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ALTER TABLE media DROP COLUMN datastore_id;
ALTER TABLE thumbnails DROP COLUMN datastore_id;
DROP INDEX datastores_index;
DROP TABLE datastores;
DROP INDEX IF EXISTS datastores_index;
DROP TABLE IF EXISTS datastores;

0 comments on commit bfbe067

Please sign in to comment.