Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range requests not properly handled anymore #457

Closed
Tracked by #415
turt2live opened this issue Aug 25, 2023 · 0 comments
Closed
Tracked by #415

Range requests not properly handled anymore #457

turt2live opened this issue Aug 25, 2023 · 0 comments
Labels
bug data waste wasted bandwidth, storage, etc release-blocker

Comments

@turt2live
Copy link
Member

There's a bit of chicken and egg going on here too. We process the Range request after the request has happened, but not before, meaning things like the download pipeline are always told -1, -1.

Problem is, most range requests from browsers contain a start but no end. We can't ask for more bytes than are available, so we need to know the possible response size before we submit the pipeline call. We don't know what the response size is until the pipeline runs though.

Somehow this needs to work.

@turt2live turt2live added bug release-blocker data waste wasted bandwidth, storage, etc labels Aug 25, 2023
@turt2live turt2live mentioned this issue Aug 25, 2023
73 tasks
turt2live added a commit that referenced this issue Sep 7, 2023
turt2live added a commit that referenced this issue Sep 7, 2023
turt2live added a commit that referenced this issue Sep 7, 2023
For #457

The download pipeline returns a CancelCloser, making this required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug data waste wasted bandwidth, storage, etc release-blocker
Projects
None yet
Development

No branches or pull requests

1 participant