Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

feat(FormInput): add autoFocus to FormInput #375

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

nating
Copy link
Contributor

@nating nating commented Nov 28, 2018

Adds autoFocus prop to the FormInput component 馃憤馃槑

@AaronCoplan
Copy link
Contributor

Hey @nating , thanks for contributing! This looks good - would you mind just uploading a screenshot of it working? After that it'll be good to merge

@nating
Copy link
Contributor Author

nating commented Nov 29, 2018

Sure, @AaronCoplan ! I tested it already but will get round to uploading a screenshot of the testing later on today 馃憣

@nating
Copy link
Contributor Author

nating commented Nov 29, 2018

@AaronCoplan , the following GIF demonstrates:

  1. Page with no FormInputs with the autoFocus property, none focus automatically when page is refreshed.
  2. One FormInput element is given the autoFocus property.
  3. When the browser is in context and the page is refreshed, the FormInput element with the autoFocus property is focused automatically.
  4. A different FormInput element is given the autoFocus property.
  5. The autoFocus also works with this other FormInput element.

forminput-autofocus-demo

Copy link
Contributor

@AaronCoplan AaronCoplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the thorough demo!

@AaronCoplan AaronCoplan merged commit 202e63e into tabler:master Nov 29, 2018
@jonthomp
Copy link
Contributor

馃帀 This PR is included in version 1.24.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants