Bump to Iceberg 1.4.0 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Sep 29, 2023
issac-lim
reviewed
Oct 10, 2023
Co-authored-by: issac-lim <sungkooc.lim@gmail.com>
nastra
reviewed
Oct 10, 2023
spark/Dockerfile
Outdated
| @@ -77,6 +75,7 @@ RUN curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2 | |||
|
|
|||
| # Add iceberg spark runtime jar to IJava classpath | |||
| ENV IJAVA_CLASSPATH=/opt/spark/jars/* | |||
| ENV JAVA_PATH="/opt/spark/jars/*" | |||
There was a problem hiding this comment.
Not sure, was a while ago. I've removed it
nastra
reviewed
Oct 10, 2023
spark/Dockerfile
Outdated
| @@ -59,14 +59,12 @@ RUN mkdir -p ${SPARK_HOME} \ | |||
| && rm -rf spark-${SPARK_VERSION}-bin-hadoop3.tgz | |||
|
|
|||
| # Download iceberg spark runtime | |||
| RUN curl https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-spark-runtime-${SPARK_MAJOR_VERSION}_2.12/${ICEBERG_VERSION}/iceberg-spark-runtime-${SPARK_MAJOR_VERSION}_2.12-${ICEBERG_VERSION}.jar -Lo /opt/spark/jars/iceberg-spark-runtime-${SPARK_MAJOR_VERSION}_2.12-${ICEBERG_VERSION}.jar | |||
| RUN curl https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-spark-runtime-${SPARK_MAJOR_VERSION}_2.12/${ICEBERG_VERSION}/iceberg-spark-runtime-${SPARK_MAJOR_VERSION}_2.12-${ICEBERG_VERSION}.jar \ | |||
| -Lo /opt/spark/jars/iceberg-spark-runtime-${SPARK_MAJOR_VERSION}_2.12-${ICEBERG_VERSION}.jar | |||
There was a problem hiding this comment.
nit: I'd prefer to have this on a single line. Same for the AWS Bundle line
There was a problem hiding this comment.
I prefer a natural break in there, but moved it to a single line
nastra
approved these changes
Oct 10, 2023
saoxia
added a commit
to saoxia/iceberg-spark
that referenced
this pull request
Oct 12, 2023
Bump to Iceberg 1.4.0 (tabular-io#93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.