fix(jira): escape summary characters correctly

The regex was wrong Fixes #549
tagoro9 · Jul 9, 2020 · 7a48209 · 7a48209
1 parent 7b65a63
commit 7a48209
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/issue-tracker/jira/Jira.ts b/src/issue-tracker/jira/Jira.ts
@@ -317,7 +317,7 @@ export class Jira implements Tracker {
         replace(/([_-])$/, ''),
         replace(/\s|\(|\)|__+/g, '_'),
         replace(/\/|\.|--=/g, '-'),
-        replace(/["$&'*,:<>?@[]`~‘’“”]/g, ''),
+        replace(/["$&'*,:;<>?@[\]`~‘’“”]/g, ''),
         toLower,
       )(issue.fields.summary),
       summary: issue.fields.summary,

diff --git a/test/issue-tracker/__snapshots__/Jira.test.ts.snap b/test/issue-tracker/__snapshots__/Jira.test.ts.snap
@@ -30,3 +30,16 @@ Object {
   "message": "There was an error",
 }
 `;
+
+exports[`jira getIssue gets and transforms the issue from Jira 1`] = `
+Object {
+  "description": undefined,
+  "id": 2928,
+  "key": "FOTINGO-4266",
+  "project": "soluta",
+  "sanitizedSummary": "issue_with_a_lot_of_characters",
+  "summary": "Issue with a lot of characters \\"$&'*,:;<>?@[]\`~‘’“”",
+  "type": "Story",
+  "url": "https://vallie.biz/browse/FOTINGO-4266",
+}
+`;