conn,device: enable cryptorouting via PeerAwareEndpoint #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an optional extension point for Endpoint that enables a path for WireGuard to inform an integration about the peer public key that is associated with an Endpoint. The API is expected to return either the same or a new Endpoint in response to this function. A future version of this patch could potentially remove the returned Endpoint, but would require larger integrator changes downstream. This adds a small per-packet cost that could later be removed with a larger refactor of the wireguard-go interface and Tailscale magicsock code, as well as introducing a generic bound for Endpoint in a device & bind instance. Updates tailscale/corp#20732
bradfitz
reviewed
Jun 8, 2024
| // | ||
| // If GetPeerEndpoint returns nil, WireGuard will be unable to respond to the peer | ||
| // until a new endpoint is written by a later packet. | ||
| type PeerAwareEndpoint interface { |
There was a problem hiding this comment.
Not going to make this a struct type instead to make the type check cheaper?
The struct can embed a conn.Endpoint and then make GetPeerEndpoint be a func field.
Or did you measure it and find it not worth it?
bradfitz
approved these changes
Jun 8, 2024
jwhited
reviewed
Jun 10, 2024
| @@ -84,6 +84,18 @@ type Endpoint interface { | |||
| SrcIP() netip.Addr | |||
| } | |||
|
|
|||
| // PeerAwareEndpoint is an optional Endpoint specialization for integratons that want to | |||
|
Do we have an associated Tailscale commit where the interface is implemented? Any idea around impact to performance? |
jwhited
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an optional extension point for Endpoint that enables a path for WireGuard to inform an integration about the peer public key that is associated with an Endpoint.
The API is expected to return either the same or a new Endpoint in response to this function. A future version of this patch could potentially remove the returned Endpoint, but would require larger integrator changes downstream.
This adds a small per-packet cost that could later be removed with a larger refactor of the wireguard-go interface and Tailscale magicsock code, as well as introducing a generic bound for Endpoint in a device & bind instance.
Updates tailscale/corp#20732