Handle variable colors that have variable fallback values #12049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We couldn't parse variables in arbitrary values which had a fallback that was itself a variable and as a result would produce nothing when such a color was used in
bg-*
ortext-*
or any other color utility.Basically this didn't work because the presence of the alpha value forces us to parse the color format:
This PR fixes it and it now produces the following CSS:
This implementation is limited because regexes are not recursive. For example, it can't handle another variable fallback like this:
Doing so would require replacing these regexes with an actual mini tokenizer and parser but that's a task for another day.
Fixes #12048