Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce quickPluginTest and quickVariantPluginTest snapshot size #12170

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Reduce quickPluginTest and quickVariantPluginTest snapshot size #12170

merged 4 commits into from
Oct 9, 2023

Commits on Oct 9, 2023

  1. sync package-lock.json

    @RobinMalfait
    RobinMalfait committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0885510 View commit details
    Browse the repository at this point in the history

  2. reduce generated examples 

    By default we use the default config when creating the quick tests for a
given plugin. However, this can result in _a lot_ of changes. For
example, when you update the opacity values, then these values will be
generated for each color, and for each plugin that uses that color.

You can see that behaviour in Adam's PR (#11832).
He added 6 values to the opacity configuration. This resulted in a diff
that looked like this:
```
+219,436 −9
```

This reduces the amount of examples for plugins that generate _a lot_ of
output otherwise.
    @RobinMalfait
    RobinMalfait committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5f6b560 View commit details
    Browse the repository at this point in the history

  3. use toMatchSnapshot 

    This way all the `quickPluginTest` and `quickVariantPluginTest`
implementations are the same. This also allows us to update tests after
config changes in an easier way because they use snapshot tests right
now.
    @RobinMalfait
    RobinMalfait committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5db0f07 View commit details
    Browse the repository at this point in the history

  4. use real colors for reduced red 

    This will make it a tiny bit easier to debug what's going on if we need
it in the future since it's using the same values as the real colors.
    @RobinMalfait
    RobinMalfait committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    de741af View commit details
    Browse the repository at this point in the history