-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't emit @config
in CSS when watching via the CLI
#12327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
Don't output
Don't emit Oct 30, 2023
@config
directive to CSS during watching@config
in CSS when watching via the CLI
thecrypticace
added a commit
that referenced
this pull request
Oct 30, 2023
This was referenced May 19, 2024
This was referenced Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the CLI and the
@config
directive, we would not remove the directive on rebuilds caused by changes to any files covered bycontent
. This would then cause the@config
directive to appear in the output CSS file. Though, a re-save of the config file would remove the directive.If you're using Tailwind CSS as a PostCSS plugin this did not happen.
This PR fixes this and now the
@config
directive is correctly removed in all cases.Fixes #12258