-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generation of utilities that use slashes in arbitrary modifiers #12515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/slashes-in-arbitrary-modifiers
branch
from
December 1, 2023 15:28
d346004
to
ff88183
Compare
thecrypticace
force-pushed
the
fix/slashes-in-arbitrary-modifiers
branch
from
December 1, 2023 15:37
ff88183
to
a091b1f
Compare
thecrypticace
added a commit
that referenced
this pull request
Dec 1, 2023
…12515) * Fix support for slashes in arbitrary modifiers * Update changelog
This was referenced May 19, 2024
This was referenced Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In utilities like
text-lg
you can specify a line-height / leading value by suffixing it with a config value or an arbitrary value.For example:
However, you couldn't use a
/
inside the arbitrary value like so:This is because we were looking for the
/
to split the utility at and we were finding the last/
(that's next to the6rem
). Now we skip over the last/
because it's inside an arbitrary value which makes sure this utility generates as expected.Fixes #12362