-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert @defaults
at start of stylesheet
#14427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwathan
commented
Sep 15, 2024
@@ -118,22 +118,20 @@ export default function resolveDefaultsAtRules({ tailwindConfig }) { | |||
} | |||
} | |||
|
|||
if (flagEnabled(tailwindConfig, 'optimizeUniversalDefaults')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conditional was unnecessary, if you look up at line 94 you can see this code is already inside a block with the exact same conditional.
if (flagEnabled(tailwindConfig, 'optimizeUniversalDefaults')) { |
adamwathan
commented
Sep 16, 2024
thecrypticace
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, we'd put all of the
@defaults
(the CSS variables and stuff) after thebase
rules. This creates an issue when usingoptimizeUniversalDefaults
with CSS that looks like this:…because the default shadow stuff ends up after the base
input
rules, so the generated styles are like this:This means all of the actual shadow values for the input are reset and the shadow doesn't work.
Fixes #14426.
Lots of failing tests right because this changes a ton of stuff, albeit in a totally inconsequential way. @thecrypticace if you could update these for me this week that would be a huge help, just banging this fix out quick while the kids are napping 😴