Don't set display: none on elements that use hidden="until-found"
#14625
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue reported by the React Aria Components team here: adobe/react-spectrum#7160 Basically `hidden="until-found"` behaves very differently than `hidden` and doesn't actually use `display: none`, so we don't want to apply the behavior we apply for the regular `hidden` attribute.
thecrypticace
approved these changes
Oct 8, 2024
|
I wonder if it’s possible to add a UI test for this? |
|
@thecrypticace probably yep, but that is only setup in v4, not v3 |
I wasn't paying close enough attention to the base branch 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported by the React Aria Components team here:
adobe/react-spectrum#7160
Basically
hidden="until-found"behaves very differently thanhiddenand doesn't actually usedisplay: none, so we don't want to apply the behavior we apply for the regularhiddenattribute.