Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't explicitly set font/line-height on body, inherit from html instead #2729

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

adamwathan
Copy link
Member

Previously we were setting the font and line-height on the body tag explicitly because of an override to body happening in modern-normalize, but I think this is actually a simpler change and makes things behave more like people expect coming from Tailwind v1.x.

@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #2729 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2729   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files         172      172           
  Lines        1737     1737           
  Branches      312      312           
=======================================
  Hits         1616     1616           
  Misses        104      104           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d57ae...3cd11c3. Read the comment docs.

@adamwathan adamwathan merged commit 9585ae1 into master Nov 4, 2020
@adamwathan adamwathan deleted the body-font-inherit branch November 4, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants