Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make font weight inherit in preflight #8078

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

bakura10
Copy link
Contributor

Hi,

This PR adds the font-weight inherit as the preflight to normalize it across browsers.

In our code we set a default font-weight of 500 on the body along other default font properties. However, for button elements, the font-weight is inherited by default on Chrome and Firefox:

image

However, on Safari, the font-weight is not inherited and default to 400:

image

This PR ensure the button is properly normalized so that everything renders consistently across browsers.

@adamwathan
Copy link
Member

Thanks! I think we can call this a bug fix since the behavior is currently inconsistent across browsers.

@adamwathan adamwathan merged commit 206f1d6 into tailwindlabs:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants