Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows separators #548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deyan-koba-zupit
Copy link

No description provided.

const globPath = join(dir, `**/*.${ASSETS_EXTENSION}`);
// glob has issues with windows separators, so we need to replace them
const globPath = join(dir, `**/*.${ASSETS_EXTENSION}`).replace(/\\/g,'/');

const files = await glob(globPath, {});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an alternative to the replacement:

Suggested change
const files = await glob(globPath, {});
const files = await glob(globPath, { windowsPathsNoEscape: true });

Not sure which is better, though.

If doing it that way, the join should probably not use a specific separator for consistency:

join(dir, '**', `*.${ASSETS_EXTENSION}`)

@brunnerh
Copy link

brunnerh commented Jun 12, 2024

This closes/fixes:

Edit: Also a duplicate of:

(Though this PR is more up to date.)

@denissonleal
Copy link

up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants