Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #75

Merged
merged 2 commits into from
Dec 24, 2020
Merged

Update README.md #75

merged 2 commits into from
Dec 24, 2020

Conversation

XhmikosR
Copy link
Contributor

  • language highlighting tweaks
  • add pissing -p switch
  • minor wording tweaks


```bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this because the highlighting didn't make a lot of sense to me:

image

But if it was intentional and preferred I can revert this :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah that doesn't really make sense I guess, so better this way :)

* language highlighting tweaks
* add pissing `-p` switch
* minor wording tweaks
tancredi
tancredi previously approved these changes Dec 24, 2020

```bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah that doesn't really make sense I guess, so better this way :)

--tag <value> CSS base tag for icons (default: i)
-u, --fonts-url <value> public url to the fonts directory (used in the generated CSS)
-u, --fonts-url <value> public URL to the fonts directory (used in the generated CSS)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but we should have it in the cli/index.ts itself (this block of options is a copy paste I've been keeping up to date of the fantasticon --help output

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Of course happy to merge first now and fix that later)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed

tancredi added a commit that referenced this pull request Dec 24, 2020
@tancredi tancredi merged commit 006e76e into tancredi:master Dec 24, 2020
@github-actions
Copy link

🎉 This PR is included in version 1.0.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

@XhmikosR XhmikosR deleted the patch-1 branch December 24, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants