feat: Allow private_ and readonly_ attrs to be set for externals

assets/chezmoi.io/docs/reference/special-files-and-directories/chezmoiexternal-format.md

@@ -26,6 +26,8 @@ Entries may have the following fields:
 | `exact`                      | bool     | `false`       | Add `exact_` attribute to directories in archive                 |
 | `exclude`                    | []string | *none*        | Patterns to exclude from archive                                 |
 | `executable`                 | bool     | `false`       | Add `executable_` attribute to file                              |
+| `private`                    | bool     | `false`       | Add `private_` attribute to file                                 |
+| `readonly`                   | bool     | `false`       | Add `readonly_` attribute to file                                |
 | `format`                     | string   | *autodetect*  | Format of archive                                                |
 | `path`                       | string   | *none*        | Path to file in archive                                          |
 | `include`                    | []string | *none*        | Patterns to include from archive                                 |

internal/chezmoi/sourcestate.go

@@ -92,6 +92,8 @@ type External struct {
 	Encrypted       bool             `json:"encrypted"       toml:"encrypted"       yaml:"encrypted"`
 	Exact           bool             `json:"exact"           toml:"exact"           yaml:"exact"`
 	Executable      bool             `json:"executable"      toml:"executable"      yaml:"executable"`
+	Private         bool             `json:"private"         toml:"private"         yaml:"private"`
+	ReadOnly        bool             `json:"readonly"        toml:"readonly"        yaml:"readonly"`
 	Checksum        externalChecksum `json:"checksum"        toml:"checksum"        yaml:"checksum"`
 	Clone           externalClone    `json:"clone"           toml:"clone"           yaml:"clone"`
 	Exclude         []string         `json:"exclude"         toml:"exclude"         yaml:"exclude"`
@@ -2489,8 +2491,8 @@ func (s *SourceState) readExternalArchiveFile(
 				Type:       SourceFileTypeFile,
 				Empty:      fileInfo.Size() == 0,
 				Executable: IsExecutable(fileInfo) || external.Executable,
-				Private:    isPrivate(fileInfo),
-				ReadOnly:   isReadOnly(fileInfo),
+				Private:    isPrivate(fileInfo) || external.Private,
+				ReadOnly:   isReadOnly(fileInfo) || external.ReadOnly,
 			}
 			sourceRelPath := parentSourceRelPath.Join(NewSourceRelPath(fileAttr.SourceName(s.encryption.EncryptedSuffix())))
 			targetStateEntry := &TargetStateFile{
@@ -2652,6 +2654,8 @@ func (s *SourceState) readExternalFile(
 	fileAttr := FileAttr{
 		Empty:      true,
 		Executable: external.Executable,
+		Private:    external.Private,
+		ReadOnly:   external.ReadOnly,
 	}
 	targetStateEntry := &TargetStateFile{
 		lazyContents: lazyContents,

internal/cmd/testdata/scripts/external.txtar

@@ -125,6 +125,12 @@ cmp $HOME/.file golden/dir/file
 [darwin] exec chezmoi managed --include=externals
 [darwin] cmp stdout golden/managed-appledouble
 
+chhome home16/user
+
+# test that readonly and private attributes are set
+[!windows] exec chezmoi apply
+[!windows] cmpmod 400 $HOME/.file
+
 -- archive/dir/file --
 # contents of dir/file
 -- golden/.file --
@@ -193,6 +199,12 @@ cmp $HOME/.file golden/dir/file
     archive:
       extractAppleDoubleFiles: true
     stripComponents: 1
+-- home16/user/.local/share/chezmoi/.chezmoiexternal.toml --
+[".file"]
+    type = "file"
+    url = "{{ env "HTTPD_URL" }}/.file"
+    private = true
+    readonly = true
 -- home2/user/.local/share/chezmoi/.chezmoiexternal.toml --
 [".file"]
     type = "file"