Skip to content

Commit

Permalink
Adjustments > Photo filters: complete overhaul
Browse files Browse the repository at this point in the history
This is one of those "if you can't beat 'em, join 'em" changes.

Photo filters are literal filters that you snap over the top of a camera lens.  They work by filtering (or in some cases, emphasizing) specific wavelengths of light, which allows for dramatic light capture that cannot be reproduced in post.

Photoshop provides a weird mimicry of these filters in its "Image > Adjustments > Photo Filter" tool.  I originally tried to outdo Photoshop by providing a much more comprehensive list of filters in PhotoDemon's version of the tool, complete with each filter's full technical name and descriptions.

Unfortunately, that made this tool an extraordinary translation burden, with 70 phrases comprising nearly 400 words of text for a single esoteric dialog.  (For perspective, that's more than 4% of PhotoDemon's total language file!)

This was insanity, and today I finally reworked this dialog to simply reproduce the same options as Photoshop.  That's the primary purpose of this tool, after all - to provide a "drop-in" replacement for Photoshop tutorials that require it.  It was silly of me to overcomplicate it in the first place, and I apologize to my translators for such an overkill implementation.

The new version of this tool is leaner, cleaner, and faster.  While here, I reworked the algorithm to operate exclusively in the CieLAB color space, which produces a higher-quality transform than Photoshop at an even faster speed than PD's old implementation.  The result is more dramatic lighting regardless of which "filter" you're applying, with especially improved results when trying to e.g. warm up a very cool photo (or cool a photo with very warm tones).
  • Loading branch information
tannerhelland committed Oct 27, 2020
1 parent aa1d7a0 commit f142633
Show file tree
Hide file tree
Showing 17 changed files with 889 additions and 5,594 deletions.
478 changes: 58 additions & 420 deletions App/PhotoDemon/Languages/French.xml

Large diffs are not rendered by default.

478 changes: 58 additions & 420 deletions App/PhotoDemon/Languages/German.xml

Large diffs are not rendered by default.

478 changes: 58 additions & 420 deletions App/PhotoDemon/Languages/Indonesian.xml

Large diffs are not rendered by default.

478 changes: 58 additions & 420 deletions App/PhotoDemon/Languages/Italian.xml

Large diffs are not rendered by default.

478 changes: 58 additions & 420 deletions App/PhotoDemon/Languages/Macedonian.xml

Large diffs are not rendered by default.

432 changes: 35 additions & 397 deletions App/PhotoDemon/Languages/Master/MASTER.xml

Large diffs are not rendered by default.

478 changes: 58 additions & 420 deletions App/PhotoDemon/Languages/Polish.xml

Large diffs are not rendered by default.

478 changes: 58 additions & 420 deletions App/PhotoDemon/Languages/Simplified_Chinese.xml

Large diffs are not rendered by default.

478 changes: 58 additions & 420 deletions App/PhotoDemon/Languages/Spanish_(Mexico).xml

Large diffs are not rendered by default.

478 changes: 58 additions & 420 deletions App/PhotoDemon/Languages/Spanish_(Spain).xml

Large diffs are not rendered by default.

448 changes: 43 additions & 405 deletions App/PhotoDemon/Languages/Traditional_Chinese.xml

Large diffs are not rendered by default.

432 changes: 35 additions & 397 deletions App/PhotoDemon/Languages/Turkish.xml

Large diffs are not rendered by default.

478 changes: 58 additions & 420 deletions App/PhotoDemon/Languages/Vlaams.xml

Large diffs are not rendered by default.

385 changes: 193 additions & 192 deletions Forms/Adjustments_Photo_PhotoFilters.frm

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Forms/MainWindow.frm
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,7 @@ Begin VB.Form FormMain
Index = 9
End
Begin VB.Menu MnuColor
Caption = "Photo filters..."
Caption = "Photo filter..."
Index = 10
End
Begin VB.Menu MnuColor
Expand Down
2 changes: 1 addition & 1 deletion Modules/Menus.bas
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ Public Sub InitializeMenus()
AddMenuItem "-", "-", 5, 13, 7
AddMenuItem "Black and white...", "adj_blackandwhite", 5, 13, 8
AddMenuItem "Colorize...", "adj_colorize", 5, 13, 9
AddMenuItem "Photo filters...", "adj_photofilters", 5, 13, 10
AddMenuItem "Photo filter...", "adj_photofilters", 5, 13, 10
AddMenuItem "Replace color...", "adj_replacecolor", 5, 13, 11
AddMenuItem "Sepia...", "adj_sepia", 5, 13, 12
AddMenuItem "Split toning...", "adj_splittone", 5, 13, 13
Expand Down
2 changes: 1 addition & 1 deletion PhotoDemon.vbp
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ Description="PhotoDemon Photo Editor"
CompatibleMode="0"
MajorVer=8
MinorVer=9
RevisionVer=133
RevisionVer=135
AutoIncrementVer=1
ServerSupportFiles=0
VersionComments="Copyright 2000-2020 Tanner Helland - photodemon.org"
Expand Down

0 comments on commit f142633

Please sign in to comment.