Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider: more reliable WebSocket server->client broadcasts #420

Closed
ptaoussanis opened this issue Feb 23, 2023 · 1 comment
Closed

Consider: more reliable WebSocket server->client broadcasts #420

ptaoussanis opened this issue Feb 23, 2023 · 1 comment
Labels
enhancement

Comments

@ptaoussanis
Copy link
Member

Currently:

  • send-buffered-server-evs>ajax-clients! has logic to allow time for possible reconnects during broadcast.
  • send-buffered-server-evs>ws-clients! does not.

I.e. Ajax broadcasts have a reliability mechanism that WS broadcasts do not.
While it's less critical for WS connections, this might be a nice feature to extend to WS broadcasts too.
@ptaoussanis
Copy link
Member Author

Closing, this will be included in forthcoming v1.18.0 release 👍

@ptaoussanis ptaoussanis mentioned this issue Feb 24, 2023
Open
ptaoussanis added a commit that referenced this issue Mar 7, 2023
@ptaoussanis
[new] [#420] More reliable WebSocket server->client broadcasts
6f6e7ee 
BEFORE THIS COMMIT

  - `send-buffered-server-evs>ajax-clients!` has logic to allow time for possible reconnects during broadcast.
  - `send-buffered-server-evs>ws-clients!` does not.

  I.e. Ajax broadcasts have a reliability mechanism that WS broadcasts do not.

AFTER THIS COMMIT

  The same reliability mechanism is now applied to both Ajax and WS broadcasts.
  The feature is far less critical for WS broadcasts, but still nice to have.
ptaoussanis added a commit that referenced this issue Mar 7, 2023
@ptaoussanis
[new] [#420] More reliable WebSocket server->client broadcasts
7dba037 
BEFORE THIS COMMIT

  - `send-buffered-server-evs>ajax-clients!` has logic to allow time for possible reconnects during broadcast.
  - `send-buffered-server-evs>ws-clients!` does not.

  I.e. Ajax broadcasts have a reliability mechanism that WS broadcasts do not.

AFTER THIS COMMIT

  The same reliability mechanism is now applied to both Ajax and WS broadcasts.
  The feature is far less critical for WS broadcasts, but still nice to have.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ptaoussanis