Start ws-kalive loop after connection is established #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the :chsk/ws-ping go-loop starts before `(connect-fn)` is called. If connection in `(connect-fn)` can't be established right away, it will enter `(retry-fn)` loop, until WS conn socket is established. Maybe it takes forever, maybe it takes just 10 seconds for the remote end to come online. Meanwhile we are sending ourselves the pings in ws-kalive-ms intervals. Basically means log gets polluted with both: "Chsk send against closed chsk." from the ws-ping send, and "Chsk is closed: will try reconnect" from the connection `retry-fn`. This change will start the go-loop only after we have returned from `(connect-fn)`.
|
@Snurppa Hi Joni, thanks for this - merging manually now! |
ptaoussanis
added a commit
that referenced
this pull request
May 31, 2022
…rppa) Before this commit: `:chsk/ws-ping` loop starts before (connect-fn) is called. This means that if there's some delay establishing connection, the logs get needlessly polluted with messages: - "Chsk send against closed chsk." from the ws-ping send. - "Chsk is closed: will try reconnect" from the connection retry-fn. After this commit: Only start the ws-kalive loop after connection is established.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the :chsk/ws-ping go-loop starts before
(connect-fn)is called.If a connection in
(connect-fn)can't be established right away, it will enter(retry-fn)loop, until WS conn socket is established. Maybe it takesforever, maybe it takes just 10 seconds for the remote end to come
online.
Meanwhile, we are sending ourselves the pings in ws-kalive-ms intervals.
Basically means log gets polluted with both:
"Chsk send against closed chsk." from the ws-ping send, and
"Chsk is closed: will try reconnect" from the connection
retry-fn.This change will start the go-loop only after we have returned from
(connect-fn).