fixing a bug in arraybuffer binary data unwrapped v2 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rosejn Hi Jeff, thanks for catching this - and for the fix! Your fix looks good to me 👍 Apologies for the trouble. Just taking care of one more PR, then will update the v1.18 snapshot. I'll ping back here when it's done 👍 |
ptaoussanis
pushed a commit
that referenced
this pull request
Apr 7, 2023
|
Merged manually, |
|
Brilliant, thanks Peter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Thanks for getting the binary support updates I made merged into mainline sente! I've finally gotten back around to moving our platform over to your latest release, and I found one minor bug that pops up when using arraybuffers (msgpack) for the binary packed format. The sente/parse-packed function is expected to always return a tuple of packed + format, but in the non string case it is only returning the packed value. With this commit everything works as expected, although I'm not 100% familiar with the v1/v2 wrapp/unwrap scheme you are using for this transition so this might not be quite write. I'm thinking maybe the (string? packed) should be the first clause in the cond, and then it should return [packed :v2/unwrapped], but maybe there are string versions that also need to do that?