Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused param jobId in Repeat .removeRepeatable() #111

Closed
polRk opened this issue Jan 13, 2020 · 4 comments
Closed

Unused param jobId in Repeat .removeRepeatable() #111

polRk opened this issue Jan 13, 2020 · 4 comments

Comments

@polRk
Copy link

polRk commented Jan 13, 2020

async removeRepeatable(name: string, repeat: RepeatOptions, jobId?: string) {

@shivagoud
Copy link

I would like to take this up and fix. I was also confused when I was going through the code. Since the documentation isn't ready yet, it makes it much more difficult to follow. Can you help me understand why it's there and what is it's original purpose @polRk @manast @stansv ?

@polRk
Copy link
Author

polRk commented Jan 14, 2020

I confused too, when I was going through the code. Perhaps this remained after the transfer from version 3?
My recommendation is to configure eslint and remove unsupported tslint from the project.

@santhosh77h
Copy link

@polRk @shivagoud @manast @stansv I think JobId is required so whenever if we schedule two repeatable jobs at the same time and want to remove only one Job so we pass that JobId and delete only that Job but the functionality of it is not implemented...

this just my guess because when I started working on this I need the above feature for my work.

will this type of functionality is implemented or it's all my guesses.

@manast
Copy link
Contributor

manast commented Oct 7, 2024

The new API removes this kind of awkwardnesses: https://docs.bullmq.io/guide/job-schedulers

@manast manast closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants