perf(retry): delete props in retryJob lua script #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
commented
Jan 25, 2022
| @@ -20,6 +21,7 @@ if (rcall("EXISTS", KEYS[1]) == 1) then | |||
| local jobId = ARGV[1] | |||
| if (rcall("ZREM", KEYS[3], jobId) == 1) then | |||
| rcall(ARGV[2], KEYS[4], jobId) | |||
| rcall("HDEL", KEYS[1], "finishedOn", "processedOn", ARGV[3]) | |||
There was a problem hiding this comment.
probably we should set attempstMade as 0 too, what do you think @manast ?
There was a problem hiding this comment.
Not sure, why would we like to reset the number of attempts here?
There was a problem hiding this comment.
if the job failed after the last attempt, if we retry the job, it would keep the last maximum attempt number
There was a problem hiding this comment.
as we are not going to reset the attempstMade, this pr should be ready
manast
reviewed
Jan 26, 2022
src/classes/job.ts
Outdated
| @@ -844,23 +844,16 @@ export class Job< | |||
| /** | |||
| * Attempts to retry the job. Only a job that has failed can be retried. | |||
There was a problem hiding this comment.
Since we can actually retry completed jobs, this comment is incorrect right now.
manast
approved these changes
Jan 26, 2022
|
🎉 This PR is included in version 1.67.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.