Refactor scripts class #1240
Merged
Refactor scripts class #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
May 12, 2022
src/classes/worker.ts
Outdated
| @@ -430,7 +430,7 @@ export class Worker< | |||
| token: string, | |||
| jobId?: string, | |||
| ): Promise<Job<DataType, ResultType, NameType>> { | |||
| const [jobData, id] = await Scripts.moveToActive(this, token, jobId); | |||
| const [jobData, id] = await this.scripts.moveToActive(this, token, jobId); | |||
There was a problem hiding this comment.
Why is needed to pass "this" in this case?
There was a problem hiding this comment.
yes, here it was missing that change, in last commit should be addressed
manast
approved these changes
May 14, 2022
src/classes/job.ts
Outdated
| } | ||
| } | ||
|
|
||
| toJSON() { | ||
| const { queue, ...withoutQueue } = this; | ||
| const { queue, scripts, ...withoutQueue } = this; |
There was a problem hiding this comment.
now it should be called: withoutQueueAndScripts. :).
In general, I think this pattern can lead to bugs because it is easy to forget to remove what you do not want and end the serialization of unneeded things. Even if more tedious, it is probably better to manually select the properties you want to serialize.
|
🎉 This PR is included in version 1.82.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.