Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(get-workers): use blockingConnection to set clientName #1255

Merged
merged 1 commit into from
May 24, 2022
Merged

fix(get-workers): use blockingConnection to set clientName #1255

merged 1 commit into from
May 24, 2022

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented May 24, 2022 •
edited
Loading

fixes #1254

@roggervalf roggervalf requested a review from manast May 24, 2022 01:32
manast
manast approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roggervalf roggervalf merged commit df796bd into master May 24, 2022
@roggervalf roggervalf deleted the fix-get-workers branch May 24, 2022 01:57
github-actions bot pushed a commit that referenced this pull request May 24, 2022
@semantic-release-bot
chore(release): 1.83.1 [skip ci]
41cc7f1 
## [1.83.1](v1.83.0...v1.83.1) (2022-05-24)

### Bug Fixes

* **get-workers:** use blockingConnection client to set clientName ([#1255](#1255)) fixes [#1254](#1254) ([df796bd](df796bd))
@github-actions
Copy link

🎉 This PR is included in version 1.83.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manast manast manast approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getter test 'gets only workers related only to one queue' inaccurate if connection = new IORedis()
2 participants
@roggervalf @manast