fix(python): respect concurrency in worker #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
Jul 15, 2023
python/bullmq/worker.py
Outdated
| @@ -59,21 +59,19 @@ async def run(self): | |||
| token_postfix = 0 | |||
|
|
|||
| while not self.closed: | |||
| if len(jobs) == 0 and len(self.processing) < self.opts.get("concurrency") and not self.closing: | |||
| while len(self.processing) < self.opts.get("concurrency") and not self.closing: | |||
There was a problem hiding this comment.
I am not sure this is a proper solution as this could result in multiple calls to BRPOPLPUSH instead of only 1, as we do on the typescript version.
There was a problem hiding this comment.
I can see it similar https://github.com/taskforcesh/bullmq/blob/master/src/classes/worker.ts#L395-L407 🤔
There was a problem hiding this comment.
Yes, the difference is the asyncQueue that avoids the excessive number of calls. It waits until BRPOPLPUSH has timedout or returned a job id. It is a bit tricky to understand the code, but that's the idea.
There was a problem hiding this comment.
at the end, the magic is handled by waiting attribute in worker class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2063