docs(groups): add warning when local concurrency is set #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
Sep 10, 2024
| @@ -14,6 +14,10 @@ const groupId = 'my group'; | |||
| await queue.setGroupConcurrency(groupId, 4); | |||
| ``` | |||
|
|
|||
| {% hint style="warning" %} | |||
| Make sure to set [Group Concurrency](concurrency.md) at worker instance level along side with local concurrency. It will work as a default concurrency for those groups that don't have a local concurrency. In this way workers will know about this feature. | |||
There was a problem hiding this comment.
Rephrase like this:
Make sure to also set the Group Concurrency at the worker instance level along side with the desired local concurrency, as it is required for this feature to function properly and also will act as a default concurrency value for the groups that have no local concurrency defined.
There was a problem hiding this comment.
I think we could also throw an exception if the local concurrency is set for a group but there is no global concurrency set.
There was a problem hiding this comment.
yeah let me think about it, also that should be implemented in pro
roggervalf
force-pushed
the
docs-local-group-conc
branch
from
e89f0f8
to
34a8256
Compare
roggervalf
force-pushed
the
docs-local-group-conc
branch
from
a30a2dd
to
44bf6fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.