Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics): differentiate points in different minutes to be more accurate #2766

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(metrics): differentiate points in different minutes to be more accurate #2766

merged 1 commit into from
Sep 10, 2024

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Sep 10, 2024 •
edited by manast
Loading

When prevTS and current time is less than 1 minute but these points belongs to different periods, they are considered in the same data point, this should not be true. Instead of rely on current time - prevTS it could be changed as in this pr

manast
manast approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, first computing the 1 minute bin and then subtracting them.

@roggervalf roggervalf merged commit 7cb670e into master Sep 10, 2024
10 checks passed
@roggervalf roggervalf deleted the fix-metrics-points branch September 10, 2024 12:36
github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
@semantic-release-bot
chore(release): 5.12.15 [skip ci]
8772a23 
## [5.12.15](v5.12.14...v5.12.15) (2024-09-10)

### Bug Fixes

* **metrics:** differentiate points in different minutes to be more accurate ([#2766](#2766)) (python) ([7cb670e](7cb670e))
* **pattern:** do not save offset when immediately is provided ([#2756](#2756)) ([a8cb8a2](a8cb8a2))
@roggervalf roggervalf mentioned this pull request Sep 10, 2024
Merged
@WontonSam WontonSam mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manast manast manast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roggervalf @manast