feat: add deduplication logic #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
Oct 4, 2024
|
|
||
| ## Fixed Mode | ||
|
|
||
| In the Fixed Mode, debouncing works by assigning a delay (Time to Live, TTL) to a job upon its creation. If a similar job (identified by a unique debouncer ID) is added during this delay period, it is ignored. This prevents the queue from being overwhelmed with multiple instances of the same task, thus optimizing the processing time and resource utilization. | ||
| In the Fixed Mode, deduplication works by assigning a delay (Time to Live, TTL) to a job upon its creation. If a similar job (identified by a unique deduplication ID) is added during this delay period, it is ignored. This prevents the queue from being overwhelmed with multiple instances of the same task, thus optimizing the processing time and resource utilization. |
There was a problem hiding this comment.
This mode should be called "Throttle" right?
|
|
||
| ## Extended Mode | ||
|
|
||
| The Extended Mode takes a different approach by extending the debouncing duration until the job's completion or failure. This means as long as the job remains in an incomplete state (neither succeeded nor failed), any subsequent job with the same debouncer ID will be ignored. | ||
| The Extended Mode takes a different approach by extending the deduplication duration until the job's completion or failure. This means as long as the job remains in an incomplete state (neither succeeded nor failed), any subsequent job with the same deduplication ID will be ignored. |
There was a problem hiding this comment.
Instead of "Extended" which does not have any semantic meaning in the actual use of this feature but more about how it is implemented, I would rename it to just: "Simple Deduplication". And move it at the top, as this mode is simpler than the throttle which requires an extra argument "ttl".
roggervalf
changed the title
roggervalf
force-pushed
the
deduplication
branch
from
1cb0852
to
fd4139e
Compare
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Oct 7, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bullmq](https://bullmq.io/) ([source](https://github.com/taskforcesh/bullmq)) | dependencies | minor | [`5.16.0` -> `5.17.1`](https://renovatebot.com/diffs/npm/bullmq/5.16.0/5.17.1) | --- ### Release Notes <details> <summary>taskforcesh/bullmq (bullmq)</summary> ### [`v5.17.1`](https://github.com/taskforcesh/bullmq/releases/tag/v5.17.1) [Compare Source](taskforcesh/bullmq@v5.17.0...v5.17.1) ##### Bug Fixes - **repeat:** also consider startDate when using "every" ([25bbaa8](taskforcesh/bullmq@25bbaa8)) ### [`v5.17.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.17.0) [Compare Source](taskforcesh/bullmq@v5.16.0...v5.17.0) ##### Bug Fixes - **sandbox:** catch exit errors ([#​2800](taskforcesh/bullmq#2800)) ([6babb9e](taskforcesh/bullmq@6babb9e)) ##### Features - **job:** add deduplication logic ([#​2796](taskforcesh/bullmq#2796)) ([0a4982d](taskforcesh/bullmq@0a4982d)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTAuMiIsInVwZGF0ZWRJblZlciI6IjM4LjExMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/201 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.